-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to JDK11 #577
Update to JDK11 #577
Conversation
These have moved to fix a split package issue. (see https://eclip.se/564544).
Build failing with expected errors about "java.lang.IllegalStateException: Command org.eclipse.jgit.api.PushCommand was called in the wrong state". Merging #575 will fix these. |
Hummm... looks like the build is now failing because of another plugin not being compatible with J11:
Update: Looks like this issue: gradle/gradle#23125. Fix is to switch GH workflows to us JDK11, (which makes sense). |
to correct JDK (Hitting gradle/gradle#23125)
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #577 +/- ##
============================================
+ Coverage 61.13% 61.15% +0.02%
Complexity 387 387
============================================
Files 81 81
Lines 1518 1519 +1
Branches 142 142
============================================
+ Hits 928 929 +1
Misses 523 523
Partials 67 67
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
@bgalek ready for review :) |
I just released 14.4.0 and added release notes that we'll be preparing axion@1.15.0 with jdk11 as base ;) |
Yep, I saw 🚀 :) |
I've created |
Breaking change: Dropping support for Java8 is a breaking change for anyone using Java8. I recommend bumping the major version.
Updates tool chain to Java 11 (LTS), and updates the JGit dependency to the latest (which requires J11). This highlighted issue #573 until the fix was merged.
Updating JGIt to the latest version also highlighted and issue with a package name change for classes in the
org.eclipse.jgit:org.eclipse.jgit.ssh.jsch
dependency: bothJschConfigSessionFactory
andOpenSshConfig
referenced fromSshConnector
have moved between JGit version 5.x.x and 6.x.x.Implications: users of the current plugin with a Gradle build environment that's pulling JGit 6.x.x will likely encounter
ClassNotFound
style errors if using theSshConnector
class.Build is now green.