Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to JDK11 #577

Merged
merged 5 commits into from
Feb 9, 2023
Merged

Update to JDK11 #577

merged 5 commits into from
Feb 9, 2023

Conversation

big-andy-coates
Copy link
Contributor

@big-andy-coates big-andy-coates commented Feb 8, 2023

Breaking change: Dropping support for Java8 is a breaking change for anyone using Java8. I recommend bumping the major version.

Updates tool chain to Java 11 (LTS), and updates the JGit dependency to the latest (which requires J11). This highlighted issue #573 until the fix was merged.

Updating JGIt to the latest version also highlighted and issue with a package name change for classes in the org.eclipse.jgit:org.eclipse.jgit.ssh.jsch dependency: both JschConfigSessionFactory and OpenSshConfig referenced from SshConnector have moved between JGit version 5.x.x and 6.x.x.

Implications: users of the current plugin with a Gradle build environment that's pulling JGit 6.x.x will likely encounter ClassNotFound style errors if using the SshConnector class.

Build is now green.

@big-andy-coates
Copy link
Contributor Author

Build failing with expected errors about "java.lang.IllegalStateException: Command org.eclipse.jgit.api.PushCommand was called in the wrong state". Merging #575 will fix these.

@big-andy-coates
Copy link
Contributor Author

big-andy-coates commented Feb 9, 2023

Hummm... looks like the build is now failing because of another plugin not being compatible with J11:

> There was a failure while executing work items
   > A failure occurred while executing org.gradle.plugin.devel.tasks.internal.ValidateAction
      > pl/allegro/tech/build/axion/release/TagPrefixConf has been compiled by a more recent version of the Java Runtime (class file version 55.0), this version of the Java Runtime only recognizes class file versions up to 52.0

Bumping com.gradle.plugin-publish to the latest 1.1.0

Update: Looks like this issue: gradle/gradle#23125. Fix is to switch GH workflows to us JDK11, (which makes sense).

@big-andy-coates big-andy-coates marked this pull request as ready for review February 9, 2023 09:12
@big-andy-coates big-andy-coates changed the title Quick test to try and highlight any other JGit issues with later version Update to JDK11 Feb 9, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #577 (671c390) into main (b84cd02) will increase coverage by 0.02%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##               main     #577      +/-   ##
============================================
+ Coverage     61.13%   61.15%   +0.02%     
  Complexity      387      387              
============================================
  Files            81       81              
  Lines          1518     1519       +1     
  Branches        142      142              
============================================
+ Hits            928      929       +1     
  Misses          523      523              
  Partials         67       67              
Impacted Files Coverage Δ
...axion/release/infrastructure/git/SshConnector.java 0.00% <ø> (ø)
...ech/build/axion/release/domain/VersionFactory.java 89.18% <0.00%> (+0.30%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@big-andy-coates
Copy link
Contributor Author

@bgalek ready for review :)

@bgalek
Copy link
Member

bgalek commented Feb 9, 2023

I just released 14.4.0 and added release notes that we'll be preparing axion@1.15.0 with jdk11 as base ;)

@big-andy-coates
Copy link
Contributor Author

Yep, I saw 🚀 :)

@bgalek
Copy link
Member

bgalek commented Feb 9, 2023

I've created v1 branch as a branch to support jdk8

@bgalek bgalek merged commit bc4ad11 into allegro:main Feb 9, 2023
@big-andy-coates big-andy-coates deleted the jdk11-test branch February 9, 2023 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants