backport remove @InputDirectory to avoid memory leak (#561) (#640) #712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v1.14.x #712 +/- ##
==========================================
Coverage 61.13% 61.13%
Complexity 387 387
==========================================
Files 81 81
Lines 1518 1518
Branches 142 142
==========================================
Hits 928 928
Misses 523 523
Partials 67 67 ☔ View full report in Codecov by Sentry. |
|
@david0 LGTM, I'll make sure to backport this version and mention you in release |
bgalek
approved these changes
Feb 15, 2024
|
@david0 released, thx for contribution |
|
Thanks for your efforts, this will help a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I do not understand in detail why this fixes #710, but it does.