Code clean-up. #75
Merged
Code clean-up. #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
vbuell
commented
May 3, 2015
vbuell
commented
- Code clean-up.
- Trim forceVersion value.
- Added logging into .tag()
| @@ -18,6 +19,7 @@ import pl.allegro.tech.build.axion.release.domain.scm.* | |||
|
|
|||
| import java.util.regex.Pattern | |||
|
|
|||
| @Slf4j | |||
There was a problem hiding this comment.
i would rather stick to Gradle project.logger thingy here
|
There is just one comment, other than that - it's perfect. Thanks for the cleanup :) i will merge as soon as you change it (please leave comment, cos otherwise i wont be notified of change). |
|
Logger issue addressed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.