Add invalid put test that make 500 error in server #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristaloleg
reviewed
Jan 16, 2019
server/server_test.go
Outdated
| } | ||
| } | ||
|
|
||
| func blob(char byte, len int) []byte { |
There was a problem hiding this comment.
There was a problem hiding this comment.
awesome , I think all blob function should be replaced to bytes.Repeat.
server/server_test.go
Outdated
|
|
||
| type errReader int | ||
|
|
||
| func (errReader) Read(p []byte) (n int, err error) { |
There was a problem hiding this comment.
Due to dropped variable for errReader everything else can be also dropped 😉
Suggested change
| func (errReader) Read(p []byte) (n int, err error) { | |
| func (errReader) Read([]byte) (int, error) { |
u5surf
force-pushed
the
improve_test_coverage
branch
from
5f99a7b
to
36e14c5
Compare
cristaloleg
previously approved these changes
Jan 17, 2019
u5surf
force-pushed
the
improve_test_coverage
branch
from
1fd6911
to
0a2a163
Compare
Signed-off-by: Y.Horie <u5.horie@gmail.com>
Signed-off-by: Y.Horie <u5.horie@gmail.com>
u5surf
force-pushed
the
improve_test_coverage
branch
from
0a2a163
to
3003fb2
Compare
siennathesane
approved these changes
Jun 17, 2019
cristaloleg
approved these changes
Jun 18, 2019
flisky
pushed a commit
to flisky/bigcache
that referenced
this pull request
May 7, 2020
* Add invalid put test that make 500 error in server Signed-off-by: Y.Horie <u5.horie@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#112
I also added some tests for which increase test coverage, made it indicated to be internal server error when PUT request in server.go