added go mod #141
added go mod #141
Conversation
Signed-off-by: Mike Lloyd <mike@reboot3times.org>
|
@janisz sorry, had to fix a pgp key issue, can you please re-review? |
| github.com/cespare/xxhash v1.1.0/go.mod h1:XrSqR1VqqWfGrhpAt58auRo0WTKS1nRRg3ghfAqPWnc= | ||
| github.com/coocood/freecache v1.1.0 h1:ENiHOsWdj1BrrlPwblhbn4GdAsMymK3pZORJ+bJGAjA= | ||
| github.com/coocood/freecache v1.1.0/go.mod h1:ePwxCDzOYvARfHdr1pByNct1at3CoKnsipOHwKlNbzI= | ||
| github.com/davecgh/go-spew v1.1.0 h1:ZDRjVQ15GmhC3fiQ8ni8+OwkZQO4DARzQgrnXU1Liz8= |
There was a problem hiding this comment.
We don't have this dependency in go.mod, that's strange that it's here 🤔
There was a problem hiding this comment.
Those are dependencies of our testing/benchmark dependencies.
$ go mod why github.com/OneOfOne/xxhash
# github.com/OneOfOne/xxhash
github.com/allegro/bigcache/caches_bench
github.com/coocood/freecache
github.com/cespare/xxhash
github.com/cespare/xxhash.test
github.com/OneOfOne/xxhash|
|
||
| require ( | ||
| github.com/cespare/xxhash v1.1.0 // indirect | ||
| github.com/coocood/freecache v1.1.0 |
There was a problem hiding this comment.
Sounds like a good task for the future: remove freecache dependency.
There was a problem hiding this comment.
It's a dependency of our benchmarking and comparison tests, not a direct dependency of bigcache itself.
There was a problem hiding this comment.
Anyway that's useless 😉
|
BTW, should we increase major version now? |
Yeah, might as well. |
|
I'm scratching my head trying to understand how is this PR /making things more portable/ as you said than what I submitted in #137? |
It doesn't, sorry for not accepting yours. I was addressing a couple things at the time and I didn't think about it, there was nothing wrong with your PR. My fault! Your contributions are still welcome, though! |
Signed-off-by: Mike Lloyd <mike@reboot3times.org>
Make things a bit more portable.
Signed-off-by: Mike Lloyd mike@reboot3times.org