DefaultConfig:change CleanWindow to 1 second #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristaloleg
previously approved these changes
Jul 9, 2019
siennathesane
previously approved these changes
Jul 9, 2019
|
@AgrimPrasad don't forget to sign your commits with PGP/GPG verification, or it can't be merged. |
Signed-off-by: Agrim Prasad <AgrimPrasad@users.noreply.github.com>
AgrimPrasad
dismissed stale reviews from siennathesane and cristaloleg
via
f3fa0b6
AgrimPrasad
force-pushed
the
defaultconfig-cleanwindow
branch
from
dfa8bc1
to
f3fa0b6
Compare
|
@mxplusb I've signed my commit with GPG verification now. Please check again. |
janisz
approved these changes
Jul 13, 2019
cristaloleg
approved these changes
Jul 13, 2019
|
Thank you @AgrimPrasad |
|
Is there a planned release any time soon? This fix is rather important, and it's not in the most recent release. |
|
@jpriebe done, please see https://github.com/allegro/bigcache/releases/tag/v2.1 |
flisky
pushed a commit
to flisky/bigcache
that referenced
this pull request
May 7, 2020
Signed-off-by: Agrim Prasad <AgrimPrasad@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue with the default config where no clean up is performed on cache if
CleanWindow: 0is specified in the config.Mentioned by @mxplusb at #139 (comment)