Deleted entries should not be removed by expire eviction #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #219 +/- ##
==========================================
+ Coverage 90.61% 90.64% +0.02%
==========================================
Files 15 15
Lines 714 716 +2
==========================================
+ Hits 647 649 +2
Misses 58 58
Partials 9 9
Continue to review full report at Codecov.
|
bachhh
force-pushed
the
master
branch
2 times, most recently
from
68a6e8e
to
da3aadf
Compare
cristaloleg
reviewed
May 5, 2020
go.mod
Outdated
| @@ -1,3 +1,5 @@ | |||
| module github.com/allegro/bigcache/v2 | |||
| module bigcache | |||
There was a problem hiding this comment.
you shouldn't change this file 😄
There was a problem hiding this comment.
oh sorry, I accidentally pushed local changes to my master
EDIT: reverted @cristaloleg
siennathesane
approved these changes
May 6, 2020
|
Fixes #126. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, this is a small fix for #126,
I think the problem is that
shard.delete()marks entries in queue as deleted ( by zero-ing all the 64 header bits for hash ), butremoveOldestEntryis not checking for this case.