Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: panic runtime error: index out of range [7] with length 0 #288

Merged
merged 3 commits into from
Sep 9, 2021

Conversation

blackbeans
Copy link
Contributor

issue : #283

场景见: bigcache_test.go#TestCache_RepeatedSetWithBiggerEntry
bigcache_test.go Outdated Show resolved Hide resolved
bigcache_test.go Outdated Show resolved Hide resolved
@janisz
Copy link
Collaborator

janisz commented Sep 7, 2021

@cristaloleg @bgalek Can you take a look at this?

@codecov-commenter
Copy link

codecov-commenter commented Sep 7, 2021

Codecov Report

Merging #288 (5f4b8d0) into master (eb759b5) will increase coverage by 2.47%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #288      +/-   ##
==========================================
+ Coverage   86.52%   88.99%   +2.47%     
==========================================
  Files          15       15              
  Lines         638      763     +125     
==========================================
+ Hits          552      679     +127     
+ Misses         71       70       -1     
+ Partials       15       14       -1     
Impacted Files Coverage Δ
shard.go 88.49% <100.00%> (+3.56%) ⬆️
utils.go 66.66% <100.00%> (+4.16%) ⬆️
fnv.go 100.00% <0.00%> (ø)
bytes.go 100.00% <0.00%> (ø)
clock.go 100.00% <0.00%> (ø)
config.go 100.00% <0.00%> (ø)
logger.go 100.00% <0.00%> (ø)
encoding.go 100.00% <0.00%> (ø)
server/middleware.go 100.00% <0.00%> (ø)
bigcache.go 99.10% <0.00%> (+0.31%) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce711ba...5f4b8d0. Read the comment docs.

cristaloleg
cristaloleg previously approved these changes Sep 8, 2021
Copy link
Collaborator

@cristaloleg cristaloleg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sgtm

@janisz
Copy link
Collaborator

janisz commented Sep 8, 2021

@blackbeans Looks like tests are failing

@blackbeans
Copy link
Contributor Author

@blackbeans Looks like tests are failing

i resubmit . TestCase should use t.Logf to print error ,not use t.Error

@janisz
Copy link
Collaborator

janisz commented Sep 8, 2021

@cristaloleg PTAL

@blackbeans blackbeans closed this Sep 8, 2021
@blackbeans blackbeans reopened this Sep 8, 2021
@blackbeans
Copy link
Contributor Author

Please merge this pull request earlier.

@janisz
Copy link
Collaborator

janisz commented Sep 9, 2021

@cristaloleg can you merge it? I have no permission to do that's :(

@cristaloleg cristaloleg changed the title fix: panic: runtime error: index out of range [7] with length 0 #283 fix: panic runtime error: index out of range [7] with length 0 Sep 9, 2021
@cristaloleg cristaloleg merged commit c2b72fe into allegro:master Sep 9, 2021
@flisky
Copy link
Contributor

flisky commented Sep 27, 2021

Could you please cut a bugfix release? Thanks!

@janisz
Copy link
Collaborator

janisz commented Sep 27, 2021

Oh, our plugin for releases is not trusted :(

toolmantim/release-drafter@v5.2.0 is not allowed to be used in allegro/bigcache.

@janisz
Copy link
Collaborator

janisz commented Sep 27, 2021

https://github.com/allegro/bigcache/releases/tag/v3.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants