Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance comparison with freecache and map #3

Merged
merged 1 commit into from
Mar 29, 2016
Merged

Performance comparison with freecache and map #3

merged 1 commit into from
Mar 29, 2016

Conversation

druminski
Copy link
Contributor

No description provided.

janisz
janisz reviewed Mar 29, 2016
View reviewed changes
caches_bench/caches_bench_test.go
"math/rand"
)

var maxEntrySize = 256
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

const?

@janisz
Copy link
Collaborator

janisz commented Mar 29, 2016

Please run gofmt, goimports and golint on changed files. We should consider adding formatting checks to .git/hooks

go get golang.org/x/tools/cmd/goimports 
go get github.com/golang/lint/golint
find ./ -name '*.go' | xargs gofmt -s -w
find ./ -name '*.go' | xargs goimports -w
golint ./...

janisz
janisz reviewed Mar 29, 2016
View reviewed changes
README.md
Results from benchmark tests are presented above.
One of the advantage of bigcache over freecache is that you don’t need to know the size of cache in advance, because
when bigcache is full, it allocates additional memory for new entries instead of overwriting existing ones as freecache does currently.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Split long lines. Next changes will be easier to review.

@druminski
Copy link
Contributor Author

@janisz I have applied your remarks

@janisz
Copy link
Collaborator

janisz commented Mar 29, 2016

LGTM 👍

@druminski druminski merged commit f7cfb18 into master Mar 29, 2016
@druminski druminski deleted the bench_tests branch March 29, 2016 15:00
@junxie6 junxie6 mentioned this pull request Dec 30, 2016
Closed
@siennathesane siennathesane mentioned this pull request Oct 11, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@druminski @janisz