Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use pool instead of entryBuffer #372

Closed
wants to merge 1 commit into from
Closed

Use pool instead of entryBuffer #372

wants to merge 1 commit into from

Conversation

valiner
Copy link

@valiner valiner commented Aug 21, 2023

Use sync.pool to get higher performance

@cristaloleg
Copy link
Collaborator

Hey, thanks for the feature. Can you re-run benchmarks?

@valiner
Copy link
Author

valiner commented Aug 21, 2023

Hey, thanks for the feature. Can you re-run benchmarks?

I reconfirmed it. It's not a good idea.

@valiner valiner closed this Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janisz janisz Awaiting requested review from janisz janisz is a code owner

@cristaloleg cristaloleg Awaiting requested review from cristaloleg cristaloleg is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@valiner @cristaloleg