Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check LifeWindow when CleanWindow is set #386

Merged
merged 2 commits into from
Nov 28, 2023
Merged

Conversation

chenyahui
Copy link
Contributor

When set CleanWindow, if LifeWindow isn't set, any data you put in will be wiped out right away. So, we need to add a check to prevent this.

@codecov-commenter
Copy link

codecov-commenter commented Nov 25, 2023

Codecov Report

Merging #386 (75e0f55) into main (93a748a) will decrease coverage by 0.72%.
The diff coverage is 50.00%.

❗ Current head 75e0f55 differs from pull request most recent head b7f5077. Consider uploading reports for the commit b7f5077 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #386      +/-   ##
==========================================
- Coverage   89.16%   88.45%   -0.72%     
==========================================
  Files          15       15              
  Lines         794      797       +3     
==========================================
- Hits          708      705       -3     
- Misses         73       77       +4     
- Partials       13       15       +2     
Files Coverage Δ
bigcache.go 91.60% <50.00%> (-1.37%) ⬇️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93a748a...b7f5077. Read the comment docs.

@janisz janisz merged commit 05b47f3 into allegro:main Nov 28, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants