Add failure domain info as tags to service #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #30 +/- ##
==========================================
- Coverage 77.2% 70.89% -6.32%
==========================================
Files 5 5
Lines 193 213 +20
==========================================
+ Hits 149 151 +2
- Misses 32 48 +16
- Partials 12 14 +2
Continue to review full report at Codecov.
|
tomez
previously approved these changes
Sep 12, 2018
tomez
approved these changes
Sep 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds cloud region and zone information from the node where the Pod is running as labels in consul if available, for consuming in external systems and easy filtering by availability zone.