service-port placeholder, marathon tag #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ojagodzinski
commented
Aug 28, 2019
•
ojagodzinski
commented
- add marathon-tag to Mesos service registations
- resolve service-port placeholder
ojagodzinski
force-pushed
the
ojag_hookupdate
branch
2 times, most recently
from
f93307e
to
0e0f9bc
Compare
ojagodzinski
force-pushed
the
ojag_hookupdate
branch
from
0e0f9bc
to
6913724
Compare
Codecov Report
@@ Coverage Diff @@
## master #38 +/- ##
=========================================
+ Coverage 75.94% 77.9% +1.95%
=========================================
Files 5 5
Lines 237 258 +21
=========================================
+ Hits 180 201 +21
Misses 39 39
Partials 18 18
Continue to review full report at Codecov.
|
AlfredBroda
approved these changes
Aug 28, 2019
tomez
approved these changes
Aug 28, 2019
| service := consul.ServiceInstance{ | ||
| ID: fmt.Sprintf("%s_%d", hostname, port.Number), | ||
| Name: consulServiceName, | ||
| Host: hostname, | ||
| Port: port.Number, | ||
| Tags: tags, | ||
| Tags: append(portTags, globalTags...), |
There was a problem hiding this comment.
mesos-executor and marathon-consul resolve placeholders also in globalTags. Here we don't resolve placeholders in global tags, which is inconsistent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.