Set idleTimeout for Jetty http client #1006
Conversation
faderskd
force-pushed
the
idle-timeout-for-jetty-http-client
branch
from
144153a
to
d1bdab4
Compare
| @@ -15,6 +15,7 @@ | |||
| private static final int DEFAULT_MESSAGE_TTL = 3600; | |||
| private static final int DEFAULT_MESSAGE_BACKOFF = 100; | |||
| private static final int DEFAULT_REQUEST_TIMEOUT = 1000; | |||
| private static final int DEFAULT_SOCKET_TIMEOUT = 0; | |||
There was a problem hiding this comment.
When you set it to 0 it will be no socket timeout at all
There was a problem hiding this comment.
So currently created subscriptions are unaffected. With this default value, only subscription's request timeouts will be respected
| // given | ||
| HttpRequestFactory httpRequestFactory = new HttpRequestFactory(client, | ||
| 100, | ||
| 100,1000, |
There was a problem hiding this comment.
| 100,1000, | |
| 100, 1000, |
There was a problem hiding this comment.
Intellij's arguments hints :D
| import com.fasterxml.jackson.annotation.JsonProperty; | ||
| import java.util.Optional; | ||
|
|
||
| public class OAuthProviderWithOptionalSocketTimeout { |
There was a problem hiding this comment.
do we really need this class (a class with such explicit name)? :) I mean, can't we just add the optional socket timeout to the existing one?
There was a problem hiding this comment.
This class is only needed to be able to fetch existing zookeeper saved oauth providers. Its implementation detail. BTW this class should be placed in infrastructure package.
This PR fixes #1004