Constraints management in hermes-console #1106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Shouldn't constraints be visible in topic/subscription views rather than in the new one? |
|
@krzysztofpcy we assumed to display topics and subscriptions separately. |
dankraw
reviewed
Sep 23, 2019
hermes-console/static/js/console/constraints/ConstraintsRepository.js
Outdated
Show resolved
Hide resolved
dankraw
reviewed
Sep 23, 2019
dankraw
reviewed
Sep 23, 2019
* Add button to remove constraints. * Redirect to /constraints-list after successful remove operation. * Add ability to edit existing constraints. * Add ability to create new constraints. * Fix add and edit operations. * Fix remove operation. * Handle dismissed remove request. * Improve info in modal. * UX improvements * UX improvements * Add forms validation.
jewertow
changed the title
dankraw
reviewed
Sep 30, 2019
| </h4> | ||
| </div> | ||
| <a class="list-group-item" ng-repeat="item in topicConstraints" ng-click="edit(item)"> | ||
| <small>{{$index + 1}}</small> |
dankraw
approved these changes
Sep 30, 2019
druminski
approved these changes
Sep 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hermes console allows to create, edit and delete constraints for topics and subscriptions.
Due to the lack of support for roles in hermes-console home view has no redirection button to constraints list. In order to go to constraints list it's necessary to manually redirect to #/constraints.