Expose creation and modification date for subscription #1158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristaloleg
previously approved these changes
Dec 19, 2019
| T t = supplier.read(data); | ||
| statDecorator.accept(t, stat); | ||
| return Optional.of(t); | ||
| } else { |
cristaloleg
previously approved these changes
Dec 22, 2019
|
@cristaloleg what date format do you expect? |
|
For me 2nd option is more preferable, 'cause it's mostly dev-oriented console, but let's ping @dankraw @druminski @piotrrzysko @faderskd 😉 |
|
@cristaloleg I pushed changes in hermes-console. Dates have format of timestamp. You can do code review. |
cristaloleg
approved these changes
Jan 27, 2020
druminski
deleted the
1123-expose-creation-and-modification-date-for-topic-and-subscription
branch
druminski
pushed a commit
that referenced
this pull request
Feb 20, 2020
* Expose creation and modification date for topic and subscription
pwolaq
pushed a commit
to pwolaq/hermes
that referenced
this pull request
Oct 15, 2020
* Expose creation and modification date for topic and subscription
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1123
For now I implemented it only for subscription. Please check it out and give me a feedback, then I will continue working.
What format of creation and modification date do you expect? Timestamp (
Long) or human-readable string ("yyyy-MM-dd'T'HH:mm:ss.SSS'Z'")?