Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolve #1267 | Audit logs for unsuccessful topic and subscription operations #1271

Merged
merged 1 commit into from Oct 6, 2020

Conversation

DyspC
Copy link
Contributor

@DyspC DyspC commented Oct 1, 2020

Hello,

This PR references issue #1267 Audit logs for unsuccessful topic and subscription operations

As discussed in this issue:

  • I added beforeObjectX methods to Auditor (default to no-op)
  • I implemented those methods in LoggingAuditor following the same log format when possible
  • I added calls to those methods in TopicService and SubscriptionService il all methods that already logged the success
  • I rearranged a bit of code around the beforeObjectUpdate calls for it to be the earliest possible (especially updateSubscriptionState)

@DyspC
Copy link
Contributor Author

DyspC commented Oct 2, 2020

I don't see any stack trace on the CI failure but when debugging the test I see subscription.endpoint is null and Subscription::anonymise is not null proof so I suppose this is the reason.

As this isn't linked to the audit enhancement and more of a general quality check I'm gonna submit another PR for this one

@druminski druminski merged commit 9a13299 into allegro:master Oct 6, 2020
pwolaq pushed a commit to pwolaq/hermes that referenced this pull request Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants