Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consumers spring DI - part 2 #1459

Merged
merged 5 commits into from Feb 14, 2022
Merged

Consumers spring DI - part 2 #1459

merged 5 commits into from Feb 14, 2022

Conversation

piotrrzysko
Copy link
Member

This PR is a follow-up to #1457.

What has been done in the PR:

  • updated documentation related to extending Hermes
  • removed dependency on a DI framework from packages other than config
  • updated versions of hibernate-validator and jersey to match those that Spring brings
  • fixed race condition on registering a consumer node in zookeeper
  • added closing the tracker module on the application shutdown - in the hk2 world it was possible to register a shutdown hook for this purpose

@piotrrzysko piotrrzysko temporarily deployed to ci February 10, 2022 12:21 Inactive
@piotrrzysko piotrrzysko mentioned this pull request Feb 11, 2022
Merged
@piotrrzysko piotrrzysko changed the base branch from consumers-spring-di to master February 11, 2022 14:39
@piotrrzysko piotrrzysko changed the base branch from master to consumers-spring-di February 11, 2022 14:41
@piotrrzysko piotrrzysko changed the base branch from consumers-spring-di to master February 11, 2022 15:26
@pitagoras3
Copy link
Contributor

I've found one more issue with current documentation in docs/docs/configuration/custom-protocol.md (but that's all 😄)

@piotrrzysko piotrrzysko merged commit 0fb614a into master Feb 14, 2022
@piotrrzysko piotrrzysko deleted the consumers-spring-di-2 branch February 15, 2022 08:02
@piotrrzysko piotrrzysko mentioned this pull request Feb 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@faderskd faderskd faderskd left review comments

@druminski druminski druminski approved these changes

@pitagoras3 pitagoras3 pitagoras3 approved these changes

@pmajorczyk-allegro pmajorczyk-allegro pmajorczyk-allegro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@piotrrzysko @pitagoras3 @druminski @faderskd @pmajorczyk-allegro