Use ephemeral ports in integration tests #1780
Conversation
| @VisibleForTesting | ||
| @SuppressWarnings("unchecked") | ||
| public int getPort() { | ||
| Field channelsField = FieldUtils.getDeclaredField(Undertow.class, "channels", true); |
There was a problem hiding this comment.
Do we need to use reflection to read Undertow port? According to a thread on Stackoverflow something like this should work:
InetSocketAddress socketAddress = (InetSocketAddress) undertow.getListenerInfo().stream().findFirst().orElseThrow(() -> new IllegalStateException("No port available yet.")).getAddress();
return socketAddress.getPort();
There was a problem hiding this comment.
Good point. I applied your suggestion. Thanks.
| @@ -151,4 +159,23 @@ private HttpHandler handlers() { | |||
| private boolean isFrontendRequestDumperEnabled() { | |||
| return hermesServerParameters.isRequestDumperEnabled(); | |||
| } | |||
|
|
|||
| @VisibleForTesting | |||
There was a problem hiding this comment.
If I understand correctly, this annotation makes the method visible in tests. So do we need this annotation when the method is public, or do we need the public access modifier?
There was a problem hiding this comment.
If I understand correctly, this annotation makes the method visible in tests.
Nope, this annotation is from Guava and doesn't change anything, it only states that the method was created only for tests. But your question is still valid whether we need it or not. When comes to me, it's ok to use it as it states explicite that the method was created only for test purposes and maybe you shouldn't use it in production.
There was a problem hiding this comment.
We don't need it. I added it just to emphasize the purpose of this method. After reconsideration, I removed it to avoid causing confusion, as we don't follow a convention of marking methods that way.
piotrrzysko
merged commit 024b170
into
integration_tests_framework
No description provided.