Rewriting tests part 2 #1790
Merged
Rewriting tests part 2 #1790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
szczygiel-m
commented
Nov 28, 2023
•
szczygiel-m
commented
- JmsConsumingTest
- FilteringJsonTest
- FilteringHeadersTest
…n-tests-part1 # Conflicts: # integration-tests/src/common/java/pl/allegro/tech/hermes/integrationtests/client/ConsumerTestClient.java # integration-tests/src/common/java/pl/allegro/tech/hermes/integrationtests/client/HermesTestClient.java # integration-tests/src/common/java/pl/allegro/tech/hermes/integrationtests/setup/HermesConsumersTestApp.java # integration-tests/src/common/java/pl/allegro/tech/hermes/integrationtests/setup/HermesExtension.java
…n-tests-part2 # Conflicts: # integration-tests/src/common/java/pl/allegro/tech/hermes/integrationtests/client/FrontendTestClient.java # integration-tests/src/common/java/pl/allegro/tech/hermes/integrationtests/client/HermesTestClient.java
…n-tests-part2 # Conflicts: # integration-tests/src/common/java/pl/allegro/tech/hermes/integrationtests/client/FrontendTestClient.java # integration-tests/src/common/java/pl/allegro/tech/hermes/integrationtests/client/HermesTestClient.java # integration-tests/src/common/java/pl/allegro/tech/hermes/integrationtests/subscriber/TestJmsSubscriber.java
moscicky
reviewed
Dec 11, 2023
| @RegisterExtension | ||
| public static final HermesExtension hermes = new HermesExtension(); | ||
|
|
||
| @BeforeAll |
There was a problem hiding this comment.
let's also perform clean up after all
moscicky
requested changes
Dec 11, 2023
moscicky
reviewed
Dec 11, 2023
| hermes.api().publishUntilSuccess(topic.getQualifiedName(), BOB_GREY.asJson()); | ||
|
|
||
| // then | ||
| subscriber.waitUntilReceived(BOB_GREY.asJson()); |
There was a problem hiding this comment.
I'd say this check is insufficient because it only checks whether BOB_GREY has been received and does not fail when receiving other messages. Can we add an assertion that only this message was received? This also applies to other filtering tests
moscicky
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.