Integration tests framework mszczygiel part3 #1797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mework_mszczygiel_part3
…mework_mszczygiel_part3 # Conflicts: # integration-tests/src/common/java/pl/allegro/tech/hermes/integrationtests/client/HermesTestClient.java # integration-tests/src/common/java/pl/allegro/tech/hermes/integrationtests/client/ManagementTestClient.java
…mework_mszczygiel_part3 # Conflicts: # integration-tests/src/common/java/pl/allegro/tech/hermes/integrationtests/client/HermesTestClient.java # integration-tests/src/common/java/pl/allegro/tech/hermes/integrationtests/client/ManagementTestClient.java
…mework_mszczygiel_part3 # Conflicts: # integration-tests/src/common/java/pl/allegro/tech/hermes/integrationtests/client/HermesTestClient.java # integration-tests/src/common/java/pl/allegro/tech/hermes/integrationtests/client/ManagementTestClient.java
moscicky
reviewed
Dec 14, 2023
|
|
||
| //TODO Fix this test later | ||
|
|
||
| // @Test |
There was a problem hiding this comment.
maybe we can use @Disabled instead of commenting this out? it would be a good reminder to have it in a summary (applies to other commented out test aswell)
moscicky
reviewed
Dec 14, 2023
| } | ||
|
|
||
| // @Test | ||
| // public void shouldCreateTopicEvenIfExistsInBrokers() { |
There was a problem hiding this comment.
what is the reason for commenting them out?
There was a problem hiding this comment.
I haven't rewritten them for the new solution yet because we don't have a framework developed for broker operations. Good point, I removed the commented tests
moscicky
reviewed
Dec 14, 2023
| @@ -38,6 +38,18 @@ public TestSubscribersExtension() { | |||
| }); | |||
| } | |||
|
|
|||
| public TestSubscribersExtension(int port) { | |||
| service = new WireMockServer(port); | |||
There was a problem hiding this comment.
no-arg constructor body can now be changed to
public TestSubscribersExtension() {
this(0);
}…mework_mszczygiel_part3 # Conflicts: # integration-tests/src/common/java/pl/allegro/tech/hermes/integrationtests/client/ManagementTestClient.java # integration-tests/src/common/java/pl/allegro/tech/hermes/integrationtests/setup/HermesInitHelper.java
moscicky
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.