migrate GooglePubSubConsumingTest to new test framework #1800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szczygiel-m
approved these changes
Dec 14, 2023
| @@ -21,23 +19,15 @@ | |||
|
|
|||
| public class AttachingKeepAliveHeaderTest { | |||
|
|
|||
| @Order(0) | |||
There was a problem hiding this comment.
Are we sure we need to use this annotation? I thought the tool was smart enough to take care of the order itself
There was a problem hiding this comment.
I'm not sure, but to me, the contract of @RegisterExtension seems too vague to assume that @Order is unnecessary in this case: https://junit.org/junit5/docs/5.4.0/api/org/junit/jupiter/api/extension/RegisterExtension.html
moscicky
approved these changes
Dec 14, 2023
...wIntegrationTest/java/pl/allegro/tech/hermes/integrationtests/GooglePubSubConsumingTest.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.