rewrite query endpoint test #1802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piotrrzysko
reviewed
Dec 15, 2023
| @@ -59,4 +73,46 @@ public void cutOffConnectionsBetweenBrokersAndClients() { | |||
| public void restoreConnectionsBetweenBrokersAndClients() { | |||
| kafka.restoreConnectionsBetweenBrokersAndClients(); | |||
| } | |||
|
|
|||
| private void removeSubscriptions() { | |||
| SubscriptionService service = management.subscriptionService(); | |||
There was a problem hiding this comment.
question: do you do this via beans instead of HTTP calls because it is easier or there are other reasons?
There was a problem hiding this comment.
I think it is beneficial in two ways:
- easier to implement
- should be more reliable (no http client involved)
The downside is that we are using implementation details (services) to clean up the storage. If they were to change test would need to be updated - but I think it is unlikely that it will happen in the foreseeable future
piotrrzysko
approved these changes
Dec 15, 2023
moscicky
force-pushed
the
query_endpoint_e2e_tests
branch
from
9837f39
to
05ac142
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All QueryEndpointTests except ones relying on prometheus stub rewritten