fix date parser in OfflineRetransmissionRequest class #1809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szczygiel-m
previously approved these changes
Dec 28, 2023
| this.startTimestamp = null; | ||
| this.endTimestamp = null; | ||
| return; | ||
| private Instant initializeTimestamps(String timestamp) { |
There was a problem hiding this comment.
nit: can be renamed to initializeTimestamp since there is only one function parameter
szczygiel-m
approved these changes
Dec 28, 2023
pitagoras3
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
context: The requests creating a task for a new retransmission, coming from the UI, have the following date format: 'yyyy-MM-dd'T'HH:mm:ss'Z'' or 'yyyy-MM-dd'T'HH:mm'Z''. If we set the date with minute precision from the UI, the request will not contain seconds at all. For example, 30.09.2023, 22:00:00 will be send as 30.09.2023, 22:00.
problem description:
We noticed that if the transmitted date has second precision (e.g., 30.09.2023, 22:00:11), it will not be handled correctly, and the user will receive an error: 'endTimestamp/startTimestamp must not be null,' which is related to how we handle requests.
This pull request adds support for a date format that includes seconds.