-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor tests stability improvements #1820
Conversation
9c40439
to
2d0885f
Compare
@@ -222,6 +224,13 @@ public void shouldNotConsumeMessagesWhenSubscriptionIsSuspended() { | |||
hermes.api().waitUntilSubscriptionActivated(topic.getQualifiedName(), subscriptionName); | |||
hermes.api().suspendSubscription(topic, subscriptionName); | |||
hermes.api().waitUntilSubscriptionSuspended(topic.getQualifiedName(), subscriptionName); | |||
// wait until consumer group removed | |||
waitAtMost(30, TimeUnit.SECONDS).until(() -> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this check be a part of "waitUntilSubscription{Suspended,Removed}()" method? Motivation, next time when a developer will write a test which calls waitUntilSubscription{Suspended,Removed}() and do some assertions after it, then without the assertion which you wrote here, the developer can receive some false-positives information. What do you think about it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch! fixed 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added one non blocking comment, +1
No description provided.