Added message retries and acquire timer metrics #1841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Diewa
previously approved these changes
Apr 5, 2024
| @@ -131,6 +136,9 @@ private int calculateMessageDelay(long publishingMessageTimestamp) { | |||
| */ | |||
| private void sendMessage(final Message message) { | |||
| loadRecorder.recordSingleOperation(); | |||
| HermesTimerContext acquireTimer = rateLimiterAcquireTimer.time(); | |||
There was a problem hiding this comment.
nit: maybe it should be moved to a separate method. What do you think?
private void acquireRateLimiter() {
HermesTimerContext acquireTimer = rateLimiterAcquireTimer.time();
rateLimiter.acquire();
acquireTimer.close();
}There was a problem hiding this comment.
Moved to a separate method
| @@ -131,6 +136,9 @@ private int calculateMessageDelay(long publishingMessageTimestamp) { | |||
| */ | |||
| private void sendMessage(final Message message) { | |||
| loadRecorder.recordSingleOperation(); | |||
| HermesTimerContext acquireTimer = rateLimiterAcquireTimer.time(); | |||
| rateLimiter.acquire(); | |||
There was a problem hiding this comment.
question: Does only ConsumerMessageSender use the send method from ResilientMessageSender?
There was a problem hiding this comment.
Actually ConsumerMessageSender use the send method from JettyBroadCastMessageSender or SingleRecipientMessageSenderAdapter depends on MessageSender implementation provided by factory. True is, that those two classes which i have mentioned are the only usages of ResilientMessageSender.send()
piotrrzysko
previously approved these changes
Apr 5, 2024
piotrrzysko
approved these changes
Apr 5, 2024
Diewa
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR contains: