Test case for lowercase header #919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dankraw
reviewed
Oct 9, 2018
| // when | ||
| HermesMessage message = hermesMessage(topic.getQualifiedName(), user.asBytes()) | ||
| .withContentType(AVRO_BINARY) | ||
| .withHeader("schema-version", "1") |
There was a problem hiding this comment.
will the test pass if you remove this header? hermes frontend uses latest schema version if no header is available.
There was a problem hiding this comment.
Test fails if you remove it with error "Invalid message: Could not deserialize avro message with provided schema"
There was a problem hiding this comment.
Hmm, and if you remove withSchemaVersionAwareSerialization() when building topic as well?
There was a problem hiding this comment.
The same error like previously.
dankraw
approved these changes
Oct 9, 2018
dankraw
approved these changes
Oct 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test for checking if headers are case-insensitive.