Improved subscription health problem indicators #972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
piotrrzysko
commented
Jan 18, 2019
piotrrzysko
commented
- Removed SlowIndicator
- Added parameters to enable/disable indicators
- Fixed indicators to respect delivery type of subscription
cristaloleg
approved these changes
Jan 18, 2019
| @@ -26,7 +27,7 @@ public SubscriptionMetrics(@JsonProperty("delivered") long delivered, @JsonPrope | |||
| @JsonProperty("otherErrors") String otherErrors, @JsonProperty("codes2xx") String codes2xx, | |||
| @JsonProperty("codes4xx") String codes4xx, @JsonProperty("codes5xx") String codes5xx, | |||
| @JsonProperty("Subscription") Subscription.State state, @JsonProperty("rate") String rate, | |||
| @JsonProperty("throughput") String throughput) { | |||
| @JsonProperty("throughput") String throughput, @JsonProperty("batchRate") String batchRate) { | |||
There was a problem hiding this comment.
Split into a separate lines please 😉
|
|
||
| public SubscriptionHealthContext(Subscription subscription, TopicMetrics topicMetrics, SubscriptionMetrics subscriptionMetrics) { |
| import pl.allegro.tech.hermes.management.domain.subscription.health.problem.SlowIndicator | ||
| import pl.allegro.tech.hermes.management.domain.subscription.health.problem.TimingOutIndicator | ||
| import pl.allegro.tech.hermes.management.domain.subscription.health.problem.UnreachableIndicator | ||
| import pl.allegro.tech.hermes.management.domain.subscription.health.problem.* |
| import static pl.allegro.tech.hermes.api.SubscriptionHealthProblem.slow | ||
| import static pl.allegro.tech.hermes.api.SubscriptionHealthProblem.timingOut | ||
| import static pl.allegro.tech.hermes.api.SubscriptionHealthProblem.unreachable | ||
| import static pl.allegro.tech.hermes.api.SubscriptionHealthProblem.* |
dankraw
reviewed
Jan 18, 2019
| if (healthProperties.isLaggingIndicatorEnabled()) { | ||
| return new LaggingIndicator(healthProperties.getMaxLagInSeconds()); | ||
| } | ||
| return new DisabledIndicator(); |
There was a problem hiding this comment.
can we store a single static instance of the DisabledIndicator and return everywhere?
druminski
approved these changes
Jan 24, 2019
piotrrzysko
changed the base branch from
descriptions-of-unhealthy-subscription
to
master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.