Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignoring portDefinitions.port field, always picking task ports #127

Merged
merged 1 commit into from Oct 5, 2016
Merged

Ignoring portDefinitions.port field, always picking task ports #127

merged 1 commit into from Oct 5, 2016

Conversation

pbetkier
Copy link
Contributor

@pbetkier pbetkier commented Oct 5, 2016

Turns out portDefinitions.port field always gets populated with some port, even if you configure it as 0 (in which case it's random). We should always read ports from task configuration.

@coveralls
Copy link

coveralls commented Oct 5, 2016 •
edited

Coverage Status

Coverage decreased (-0.03%) to 79.181% when pulling 20d561e on fix_ports_with_port_definitions into 90e5739 on develop.

janisz
janisz approved these changes Oct 5, 2016
View reviewed changes
Copy link
Contributor

@janisz janisz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deleting code always looks good to me 👍

@pbetkier pbetkier merged commit 4b45598 into develop Oct 5, 2016
@janisz janisz deleted the fix_ports_with_port_definitions branch February 17, 2017 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janisz janisz janisz approved these changes

@dankraw dankraw dankraw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@pbetkier @coveralls @janisz @dankraw @adamdubiel