Multiple checks, fix for url encoding, TCP/Command checks #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| return nil | ||
|
|
||
| spew.Dump(checks) |
There was a problem hiding this comment.
Hold on :) I'm trying to test this PR as on my macbook tests are always failing 🌴
|
Ready to review 🙏 |
| Command: struct { | ||
| Value string `json:"value` | ||
| }{Value: "echo 1"}, | ||
| IntervalSeconds: 30, |
There was a problem hiding this comment.
Maybe add one unknown check to show it'll be ignored
There was a problem hiding this comment.
Missing one test case with HTTP protocol and invalid path
There was a problem hiding this comment.
Added test case with invalid path
|
👍 |
|
@wendigo One more thing. Could you squash your commits into one? |
|
Squashed. |
|
nice! 👍 |
|
Thanks @wendigo ! |
|
Yeah! 😎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #61, #67