Skip to content

Commit

Permalink
Change to versioning only by git tag (#108)
Browse files Browse the repository at this point in the history
Versioning based on VERSION file was not practical and generated a
lot of mistakes when releasing new versions.
  • Loading branch information
medzin committed Apr 5, 2018
1 parent 8e20ab0 commit d286a53
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 6 deletions.
3 changes: 2 additions & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ deploy:
api_key:
secure: OxoxKpT3pTj5JjX2Pyfs/69RRzJ+uMwErvLYKCc7UwFvG3plag/qcJgawMLmqPg/xQ1KHeo8cdkIvbJkDRLH09e15YX3xNDCB2a/REGxqMs8iMBO7cWPWVYaNn925g1ffYEKR59csNib1ugkBRszeLhvCuvFG48NaSOU2fJyUdhbruh5xWrE8cJ6xRvUK1bwqMt4n5jPsHP4KlfRp3l3Jy/iDYogwnXanFSNGkZ6qPBYnY4I1b31T1podQtNjUKI5yKvd/Op3LoBu3z9EdhDpOykzs08LspcLo09Hn2c1RPilxmDwlfSni9EWIIMCgjFARiuXyxcyMzs6v9qf+WzBC7AnHy/KPIXfXIoSSDjV5oNgHIkvWdRKTGc3G4i0YmoxNx+ll4C71LMUT2t4X1zGMBA+E07Qioaq0dtXDemyQH51eiD0GpPk+35cK97pNY/CtdUNfJlerRa8wIxjk1yiFE+8K1vePXiA5xsDMiyIAQcv44W487+JEV29NnOnFoRU6PXMtQits+PWvn0BaJvCtQmodX9zQYkREy+h8RNST+IHJWi5SgSHqC8fmTbXi1iuGLq5kpR3TZvCrY52WZh/eWc7cyWTpZR6cJAX7OZcJguZRGPI4A740rCucnqkiyNltDPeArpkSnNIbY/go3XgtttsVycHjtYm8XhAJpo0A4=
skip_cleanup: true
file: target/executor-linux-amd64.zip
file_glob: true
file: target/*.zip
on:
tags: true
7 changes: 3 additions & 4 deletions Makefile
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
APPLICATION_NAME := github.com/allegro/mesos-executor
APPLICATION_VERSION := $(shell cat VERSION)
APPLICATION_VERSION := $(shell git describe --tags || echo "unknown")

LDFLAGS := -X main.Version=$(APPLICATION_VERSION)
USER_ID := `id -u $$USER`

BUILD_FOLDER := target

Expand Down Expand Up @@ -45,8 +44,8 @@ lint-deps:
(go get -u -v gopkg.in/alecthomas/gometalinter.v2 && gometalinter.v2 --install)

package: build
zip -j $(BUILD_FOLDER)/executor-linux-amd64.zip $(BUILD_FOLDER)/executor
chmod 0755 $(BUILD_FOLDER)/executor-linux-amd64.zip
zip -j $(BUILD_FOLDER)/executor-$(APPLICATION_VERSION)-linux-amd64.zip $(BUILD_FOLDER)/executor
chmod 0755 $(BUILD_FOLDER)/executor-$(APPLICATION_VERSION)-linux-amd64.zip
chmod 0777 $(BUILD_FOLDER)

test: $(COVERAGEDIR)/coverage.out
Expand Down
1 change: 0 additions & 1 deletion VERSION

This file was deleted.

0 comments on commit d286a53

Please sign in to comment.