Consul hook: add service port tag for proxy ports #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlfredBroda
reviewed
Jul 9, 2019
MarcinFalkowski
force-pushed
the
consul-add-service-port-tag
branch
from
83455d9
to
3ee66f9
Compare
Codecov Report
@@ Coverage Diff @@
## master #129 +/- ##
==========================================
- Coverage 72.68% 72.63% -0.06%
==========================================
Files 34 34
Lines 1501 1509 +8
==========================================
+ Hits 1091 1096 +5
- Misses 335 337 +2
- Partials 75 76 +1
Continue to review full report at Codecov.
|
deejay1
approved these changes
Jul 9, 2019
AlfredBroda
approved these changes
Jul 9, 2019
MarcinFalkowski
added a commit
to MarcinFalkowski/mesos-executor
that referenced
this pull request
Jul 10, 2019
This reverts commit 844a16b.
AlfredBroda
pushed a commit
that referenced
this pull request
Jul 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.