New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for HP iLO + bugfix for GetFromRalph method. #15
Conversation
import hpilo | ||
|
||
|
||
USER = os.environ['MANAGEMENT_USER_NAME'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
imo we should unify somehow these parameters. some are passed as a script param (ex. IP address), some are taken from env variables. Maybe we could use sth similar to this: http://stackoverflow.com/a/10551190/761782 - then we could specify variable either by env variable or by script param?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's intentional :) You most certainly do not want to pass any sensible data (e.g. credentials) via script params. But I see your point, and I think that moving IP address argument to env var would be a good move here (these scripts are not meant to be launched directly by user anyway...).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done (credentials and IP address are taken only from env vars).
🆗 |
🆗 |
Fix for GetFromRalph method (not checking response status codes).
This PR should not be merged before #14.