Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for HP iLO + bugfix for GetFromRalph method. #15

Merged
merged 2 commits into from Jun 13, 2016
Merged

Support for HP iLO + bugfix for GetFromRalph method. #15

merged 2 commits into from Jun 13, 2016

Conversation

xor-xor
Copy link
Contributor

@xor-xor xor-xor commented Jun 10, 2016

This PR should not be merged before #14.

@coveralls
Copy link

Coverage Status

Coverage increased (+5.8%) to 56.552% when pulling 7d75a37 on xor-xor:ilo into 7ad7609 on allegro:develop.

import hpilo


USER = os.environ['MANAGEMENT_USER_NAME']
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

imo we should unify somehow these parameters. some are passed as a script param (ex. IP address), some are taken from env variables. Maybe we could use sth similar to this: http://stackoverflow.com/a/10551190/761782 - then we could specify variable either by env variable or by script param?

Copy link
Contributor Author

@xor-xor xor-xor Jun 12, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's intentional :) You most certainly do not want to pass any sensible data (e.g. credentials) via script params. But I see your point, and I think that moving IP address argument to env var would be a good move here (these scripts are not meant to be launched directly by user anyway...).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done (credentials and IP address are taken only from env vars).

@coveralls
Copy link

Coverage Status

Coverage increased (+6.0%) to 56.751% when pulling 820cb8b on xor-xor:ilo into 7ad7609 on allegro:develop.

@quamilek
Copy link
Member

🆗

@mkurek
Copy link

mkurek commented Jun 13, 2016

🆗

@coveralls
Copy link

Coverage Status

Coverage increased (+6.0%) to 56.751% when pulling 1ec892d on xor-xor:ilo into 7ad7609 on allegro:develop.

Tomasz Mieszkowski added 2 commits June 13, 2016 14:49
Fix for GetFromRalph method (not checking response status codes).
@coveralls
Copy link

Coverage Status

Coverage increased (+1.4%) to 56.751% when pulling 37c3cc9 on xor-xor:ilo into af23a83 on allegro:develop.

@xor-xor
Copy link
Contributor Author

xor-xor commented Jun 13, 2016

@mkurek + @quamilek - my last activity in this PR (i.e., after you both accepted it) looks like two commits have been added, but it's just a resolution of merge conflict by making two cherry picks - nothing has changed.

@xor-xor xor-xor merged commit bbb4912 into allegro:develop Jun 13, 2016
@xor-xor xor-xor deleted the ilo branch June 13, 2016 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants