Skip to content

Commit

Permalink
Bugfix with sending data to DNSSaaS (#2821)
Browse files Browse the repository at this point in the history
  • Loading branch information
szok committed Sep 28, 2016
1 parent 1d687e3 commit 076b84a
Showing 1 changed file with 19 additions and 6 deletions.
25 changes: 19 additions & 6 deletions src/ralph/dns/dnsaas.py
Expand Up @@ -192,11 +192,21 @@ def create_dns_record(self, record):
'domain': domain,
'owner': settings.DNSAAS_OWNER
}
return self._post(url, data)
return self._post(url, data)[1]

def _post(self, url, data):
"""
Send post data to URL.
Args:
url: str endpoint url
data: dict to send
Returns:
tuple (response status code, dict data)
"""
response = self.session.post(url, json=data)
return self._response2result(response)
return response.status_code, self._response2result(response)

def delete_dns_record(self, record_id):
"""
Expand Down Expand Up @@ -244,7 +254,10 @@ def send_ipaddress_data(self, ip_record_data):
"""
logger.info('Send update data: {}'.format(ip_record_data))
url = self.build_url('ip_record')
response = self._post(url, ip_record_data)
if response.status_code >= 400:
logger.error('DNSaaS returned {}'.format(response.status_code))
return response.json()
status_code, response_data = self._post(url, ip_record_data)
if status_code >= 400:
logger.error(
'DNSaaS returned {} data: {}'.format(
status_code, str(response_data)
)
)

0 comments on commit 076b84a

Please sign in to comment.