Display only dhcp broadcast network in Deployment form (#2841)

src/ralph/data_center/models/physical.py

@@ -348,11 +348,16 @@ def _get_available_network_environments(self):
             ).distinct())
         return NetworkEnvironment.objects.none()
 
-    def _get_available_networks(self, as_query=False):
+    def _get_available_networks(
+        self, as_query=False, is_broadcasted_in_dhcp=False
+    ):
         if self.rack_id:
             query = Network.objects.filter(racks=self.rack_id).distinct()
         else:
             query = Network.objects.none()
+        if is_broadcasted_in_dhcp:
+            query = query.filter(dhcp_broadcast=True)
+
         return query if as_query else list(query)
 
     class Meta:

src/ralph/data_center/tests/test_models.py

@@ -291,6 +291,16 @@ def test_get_available_networks(self):
             [self.net, self.net2]
         )
 
+    def test_get_available_networks_is_broadcasted_in_dhcp(self):
+        self._prepare_rack(self.dc_asset, '192.168.1.1', '192.168.1.0/24')
+        self.net3 = NetworkFactory(
+            address='192.168.3.0/24', dhcp_broadcast=True
+        )
+        self.assertCountEqual(
+            self.dc_asset._get_available_networks(is_broadcasted_in_dhcp=True),
+            [self.net, self.net2]
+        )
+
     def test_get_available_networks_no_rack(self):
         NetworkFactory(address='192.168.1.0/24')
         NetworkFactory(address='192.168.2.0/24')

src/ralph/deployment/deployment.py

@@ -138,7 +138,9 @@ def next_free_ip_choices(actions, objects):
     """
     networks = []
     for obj in objects:
-        networks.append(set(obj._get_available_networks()))
+        networks.append(set(obj._get_available_networks(
+            is_broadcasted_in_dhcp=True
+        )))
     # get common part
     networks = set.intersection(*networks)
     ips = [