docker sensible-editor editor not working (Vim, Vim.tiny, Nano, Nano-tiny)

[triple-it]

Suggested Fix

diff --git a/Makefile b/Makefile
index a1ee732c0..0780c8827 100644
--- a/Makefile
+++ b/Makefile
@@ -32,7 +32,7 @@ build-package:
 # snapshot version of the package. It is mainly used for testing.
 build-snapshot-package:
        docker build --force-rm -f docker/Dockerfile-deb -t ralph-deb:latest .
-       docker run --rm -v $(shell pwd):/volume ralph-deb:latest build-snapshot-package
+       docker run --tty --interactive --rm -v $(shell pwd):/volume ralph-deb:latest build-snapshot-package
        docker image rm --force ralph-deb:latest

Steps to reproduce

make build-snapshot-package

• VERSION=20200828.1
• [[ 20200828.1 == \S\N\A\P\S\H\O\T ]]
• VERSION_PARAMS=--release
• echo 20200828.1
  20200828.1
• gbp dch --ignore-branch --git-author --spawn-editor=release --new-version 20200828.1 --release
  gbp:info: Changelog last touched at 'ec9d42ca97bdaf6f48b8dd5d23abc0018b6fa70e'
  gbp:info: No changes detected from ec9d42c to HEAD.
  /usr/bin/sensible-editor: 25: /usr/bin/sensible-editor: nano: not found
  /usr/bin/sensible-editor: 28: /usr/bin/sensible-editor: nano: not found
  /usr/bin/sensible-editor: 31: /usr/bin/sensible-editor: nano-tiny: not found
  Vim: Warning: Output is not to a terminal
  Vim: Warning: Input is not from a terminal

Expected behavior

Succesful "make build-snapshot-package" execution

Actual behavior

The docker environment is not run interactively so not capable of doing input on the TERM.

Environment

Distributor ID: Ubuntu
Description: Ubuntu 20.04.1 LTS
Release: 20.04
Codename: focal

• Ralph version: 20200828.1
• Operating system: Ubuntu 20.04.1 LTS
• Method of installation: Deb package? Manual installation? Docker?

Git clone --> Docker

[romcheg]

@triple-it Thanks for the report and for the proposed fix. Would you like to submit those changes as a PR? Otherwise I will do it.