Removed module 'ralph.util.pricing' and the code that relates to it. #1035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrzej-jankowski
added a commit
that referenced
this pull request
Aug 28, 2014
Removed module 'ralph.util.pricing' and the code that relates to it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ralph.util.pricingwas a really old piece of code, causing some really weird problems recently, like changing some fields on devices (e.g.rack). This pull request removes this module and the code that relates to it (e.g. tests).It should be considered as a part of larger operation (removal of some old views from Ralph, like 'Costs', 'Prices' and 'Reports') - therefore, there are some places marked as
a leftover from ralph.util.pricing, which should be re-examined during that operation.