Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed settings position in settings file. #1307

Merged
1 commit merged into from Feb 10, 2015
Merged

Fixed settings position in settings file. #1307

1 commit merged into from Feb 10, 2015

Conversation

ghost
Copy link

@ghost ghost commented Feb 10, 2015

Before, DEFAULT_REGION_NAME (and SYNC_FIELD_MIXIN_NOTIFICATIONS_WHITELIST) was
below code loading ~/.ralph/settings which disallows change
DEFAULT_REGION_NAME (and SYNC_FIELD_MIXIN_NOTIFICATIONS_WHITELIST) in
~/.ralph/settings.
This change fixes that

@mkurek
Copy link
Contributor

mkurek commented Feb 10, 2015

Move SYNC_FIELD_MIXIN_NOTIFICATIONS_WHITELIST before loading settings too.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 51.17% when pulling 470c08d on xliiv:fix/region-setting into 3fb2c03 on allegro:develop.

Before, DEFAULT_REGION_NAME (and SYNC_FIELD_MIXIN_NOTIFICATIONS_WHITELIST) was
below code loading ~/.ralph/settings which disallows change
DEFAULT_REGION_NAME (and SYNC_FIELD_MIXIN_NOTIFICATIONS_WHITELIST) in
~/.ralph/settings.
This change fixes that.
@ghost ghost changed the title Fixed DEFAULT_REGION_NAME settings position. Fixed settings position in settings file. Feb 10, 2015
@coveralls
Copy link

Coverage Status

Coverage remained the same at 51.17% when pulling 819f2e5 on xliiv:fix/region-setting into 3fb2c03 on allegro:develop.

@mkurek
Copy link
Contributor

mkurek commented Feb 10, 2015

🆗

1 similar comment
@andrzej-jankowski
Copy link
Contributor

🆗

ghost pushed a commit that referenced this pull request Feb 10, 2015
Fixed settings position in settings file.
@ghost ghost merged commit 11d3bf0 into allegro:develop Feb 10, 2015
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants