Fixed frozen request when content-length equals 0 #1520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🆗 |
| response.raise_for_status() | ||
| headers, content = response.headers, response.content | ||
| except requests.exceptions.RequestException as e: | ||
| logger.error("Exception: {} for url: {}".format(e, url)) | ||
| session.close() |
There was a problem hiding this comment.
shouldn't this be in some finally block?
There was a problem hiding this comment.
maybe better than finally block will be with statement around whole try..execpt blocks?
Prevent freezing request in ``get_http_info``.
ar4s
force-pushed
the
fix-frozen-requests
branch
from
c999d0f
to
cb7347e
Compare
|
🆗 |
ar4s
added a commit
that referenced
this pull request
Jun 24, 2015
Fixed frozen request when content-length equals 0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent freezing request in
get_http_info.