Fixed exporting asset type and status #1816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🆗 |
|
Your commit message: |
In Ralph NG, there is separated asset status for BO and DC (introduced in allegro#1815). This PR fixes export of BO and DC asset statuses to be compatible with NG.
mkurek
force-pushed
the
exporter-asset-status-2
branch
from
1bd4bd1
to
de881f1
Compare
|
@vi4m done |
|
It should be done with separate package called ralph-interop with DI. Instead, we did just a bastard child of two systems, mixing them, and breaking Classes Encapsulation rules . This horrible practice should be punished, and this pull request should not be merged. But... Fuck it. New world is coming, let's spend our energy on Ralph-NG instead! :) |
|
LLCBDSOTOT |
mkurek
added a commit
that referenced
this pull request
Oct 6, 2015
Fixed exporting asset type and status
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Ralph NG, there is separated asset status for BO and DC (introduced in #1815). This PR fixes export of BO and DC asset statuses to be compatible with NG.