settings for redis sentinel #3266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkurek
reviewed
May 9, 2018
src/ralph/settings/base.py
Outdated
| REDIS_MASTER_IP = None | ||
| REDIS_MASTER_PORT = None | ||
|
|
||
| REDIS_SENTINEL_ENABLED = os.environ.get('REDIS_SENTINEL_ENABLED', 'false').lower() == 'true' # noqa: E501 |
src/ralph/settings/base.py
Outdated
| REDIS_CONNECTION = { | ||
| 'HOST': os.environ.get('REDIS_HOST', 'localhost'), | ||
| 'PORT': os.environ.get('REDIS_PORT', '6379'), | ||
| 'HOST': REDIS_MASTER_IP if REDIS_MASTER_IP else os.environ.get('REDIS_HOST', 'localhost'), # noqa: E501 |
There was a problem hiding this comment.
why not REDIS_MASTER_IP or os.environ.get('REDIS_HOST', 'localhost')?
There was a problem hiding this comment.
you're right, or looks better
romcheg
reviewed
May 9, 2018
src/ralph/settings/base.py
Outdated
|
|
||
| sentinel = Sentinel( | ||
| [tuple(s_host.split(':')) for s_host in SENTINEL_HOSTS], | ||
| socket_timeout=0.2 |
There was a problem hiding this comment.
I think it'd be better allow to parameterize this timeout as well.
mkurek
reviewed
May 9, 2018
src/ralph/settings/base.py
Outdated
| from redis.sentinel import Sentinel | ||
|
|
||
| # SENTINEL_HOSTS env variable format: host_1:port;host_2:port | ||
| SENTINEL_HOSTS = os.environ['SENTINEL_HOSTS'].split(';') |
There was a problem hiding this comment.
consider naming it REDIS_SENTINEL_HOSTS
romcheg
reviewed
May 9, 2018
romcheg
approved these changes
May 9, 2018
mkurek
approved these changes
May 9, 2018
ar4s
approved these changes
May 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.