Introduce Access Card management #3506
Conversation
| blank=True, | ||
| help_text=_('Optional notes') | ||
| ) | ||
| user = models.ForeignKey( |
There was a problem hiding this comment.
Please add on_delete attribute. I recommend you on_delete=models.SET_NULL in this case.
There was a problem hiding this comment.
Are there any limits? Can every user have an unlimited number of cards?
There was a problem hiding this comment.
Yes, User can have any number of cards.
src/ralph/access_cards/models.py
Outdated
| RalphUser, | ||
| null=True, | ||
| blank=True, | ||
| related_name='used_access_cards', |
There was a problem hiding this comment.
I don't see any usage of backward relation. Please consider + if you don't need.
src/ralph/access_cards/models.py
Outdated
| RalphUser, | ||
| null=True, | ||
| blank=True, | ||
| related_name='owned_access_cards', |
| blank=True, | ||
| help_text=_('Optional notes') | ||
| ) | ||
| user = models.ForeignKey( |
There was a problem hiding this comment.
Are there any limits? Can every user have an unlimited number of cards?
| ) | ||
|
|
||
| def __str__(self): | ||
| return _('Access Card: {}').format(self.visual_number) |
There was a problem hiding this comment.
It's better override the default autocomplete queryset in order to filter out liquidated cards.
def get_autocomplete_queryset(cls):
return cls._default_manager.exclude(
status=AccessCardStatus.liquidated.id
)```
| 'visual_number':'654321', | ||
| 'system_number':'F9876DSGV', | ||
| 'notes':'test note', | ||
| 'issue_date':'2020-01-02' |
There was a problem hiding this comment.
region is a required field
| class AccessCardFactory(DjangoModelFactory): | ||
| visual_number = factory.Sequence(lambda n: '000000000000{}'.format(n)) | ||
| system_number = factory.Sequence(lambda n: '000000000000{}'.format(n)) | ||
| status = AccessCardStatus.new |
There was a problem hiding this comment.
region is a required field
| ) | ||
| self.assertEqual( | ||
| response_data['owner']['username'], | ||
| access_card.owner.username |
There was a problem hiding this comment.
Need to check the region as well.
No description provided.