Feature/onstor collects diskshare informations #953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kula1922
commented
Jul 7, 2014
kula1922
commented
- Onstor plugin collects diskshare informations
| @@ -13,6 +13,7 @@ | |||
| from ralph.scan.plugins import get_base_result_template | |||
| from ralph.util import parse | |||
| from ralph.util.network import connect_ssh, check_tcp_port | |||
| from ralph.discovery.models import DiskShare | |||
There was a problem hiding this comment.
Append this import to line 11.
| } | ||
| ) | ||
| return disk_shares | ||
|
|
There was a problem hiding this comment.
What about some basic unit tests for those 3 functions above..?
|
Update CHANGELOG txt |
| finally: | ||
| ssh.close() | ||
| return device_info | ||
|
|
||
|
|
||
| def scan_address(ip_address, **kwargs): | ||
| if kwargs.get('http_family') not in ('sscccc',): | ||
| if kwargs.get('http_family') not in ('sscccc'): |
There was a problem hiding this comment.
I'd rather leave this comma here (previously it was a tuple, now it's just a string). Consider this:
'a' in ('aaa',)
False
'a' in ('aaa')
True
xor-xor
added a commit
that referenced
this pull request
Jul 9, 2014
…re-informations Feature/onstor collects diskshare informations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.