Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved 'DNS Records' form validation (detection of duplicate records). #997

Merged
merged 3 commits into from
Jul 29, 2014
Merged

Conversation

xor-xor
Copy link
Contributor

@xor-xor xor-xor commented Jul 28, 2014

No description provided.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 52c873e on xor-xor:ralph_1813 into * on allegro:develop*.

ptr = self.cleaned_data.get('ptr', False)
if not self.cleaned_data.get('id'):
r = Record.objects.get(name=name, type=type, content=content)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if Record.objects.get(name=name, type=type, content=content).exists() will be better.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling bba6747 on xor-xor:ralph_1813 into * on allegro:develop*.

andrzej-jankowski added a commit that referenced this pull request Jul 29, 2014
Improved 'DNS Records' form validation (detection of duplicate records).
@andrzej-jankowski andrzej-jankowski merged commit eefd605 into allegro:develop Jul 29, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants