Feature/team average billing model #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -108,8 +108,9 @@ def _get_report_data(cls, start, end, is_active, forecast, ventures): | |||
| logger.warning( | |||
| "Usage '{0}' have no usage plugin".format(plugin.name) | |||
| ) | |||
| except BaseException as e: | |||
| except Exception as e: | |||
| logger.exception("Report generate error: {0}".format(e)) | |||
There was a problem hiding this comment.
Error generating the report: ...
| @@ -108,8 +108,11 @@ def _get_report_data(cls, start, end, is_active, forecast, ventures): | |||
| logger.warning( | |||
| "Usage '{0}' have no usage plugin".format(plugin.name) | |||
| ) | |||
| except BaseException as e: | |||
| logger.exception("Report generate error: {0}".format(e)) | |||
| except Exception as e: | |||
There was a problem hiding this comment.
why not BaseException? Exception inherit from BaseException
There was a problem hiding this comment.
because we don't want to catch BaseExceptions - ex. SystemExit or KeyboardInterrupt
kula1922
added a commit
that referenced
this pull request
Jun 23, 2014
Feature/team average billing model
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
team average billing model