Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Usage type endpoint to API v0.10 #549

Merged
merged 2 commits into from
Nov 17, 2016
Merged

Add Usage type endpoint to API v0.10 #549

merged 2 commits into from
Nov 17, 2016

Conversation

szok
Copy link
Contributor

@szok szok commented Nov 15, 2016 •
edited
Loading

No description provided.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.07%) to 84.886% when pulling 103ca4a on szok:usage-type-api into c6539fa on allegro:develop.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.07%) to 84.886% when pulling 103ca4a on szok:usage-type-api into c6539fa on allegro:develop.

@coveralls
Copy link

coveralls commented Nov 15, 2016 •
edited
Loading

Coverage Status

Coverage increased (+0.1%) to 84.886% when pulling b6489d1 on szok:usage-type-api into 1738d26 on allegro:develop.

mkurek
mkurek reviewed Nov 15, 2016
View reviewed changes
src/ralph_scrooge/rest/v010/views.py
from rest_framework.filters import BaseFilterBackend


class SymbolFilterBackend(BaseFilterBackend):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Imo all this filtering by multiple symbole is not necessary.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@coveralls
Copy link

coveralls commented Nov 16, 2016 •
edited
Loading

Coverage Status

Coverage increased (+0.1%) to 84.861% when pulling 3f4c5fc on szok:usage-type-api into 1738d26 on allegro:develop.

@coveralls
Copy link

coveralls commented Nov 16, 2016 •
edited
Loading

Coverage Status

Coverage increased (+0.1%) to 84.864% when pulling ff16434 on szok:usage-type-api into 1738d26 on allegro:develop.

@coveralls
Copy link

coveralls commented Nov 16, 2016 •
edited
Loading

Coverage Status

Coverage increased (+0.1%) to 84.864% when pulling d532c9b on szok:usage-type-api into 1738d26 on allegro:develop.

@mkurek mkurek merged commit 71a4bd7 into allegro:develop Nov 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkurek mkurek mkurek approved these changes

@xor-xor xor-xor xor-xor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@szok @coveralls @mkurek @xor-xor