Add management command for costs report pre-validation #610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
xor-xor
suggested changes
Apr 25, 2017
| from datetime import datetime | ||
|
|
||
|
|
||
| def valid_date(date_): |
There was a problem hiding this comment.
It is in utils already: https://github.com/allegro/ralph_pricing/blob/develop/src/ralph_scrooge/utils/common.py#L130 ;) What about importing it as valid_date to your mgmt command..?
There was a problem hiding this comment.
True, I'll fix it :)
mkurek
force-pushed
the
validation-mgmt-cmd
branch
from
e902be4
to
910ecba
Compare
1 similar comment
xor-xor
suggested changes
Apr 26, 2017
|
|
||
| from django.core.management.base import BaseCommand | ||
|
|
||
| from ralph_scrooge.utils.common import validate_date |
There was a problem hiding this comment.
s/validate_date/validate_date as valid_date/
| def add_arguments(self, parser): | ||
| parser.add_argument( | ||
| '--date', | ||
| type=validate_date, |
There was a problem hiding this comment.
s/validate_date/valid_date/
| class Command(BaseCommand): | ||
| """ | ||
| Detect if there is cycle in charging between PricingServices for given date | ||
| """ | ||
| def add_arguments(self, parser): | ||
| parser.add_argument( | ||
| '--date', | ||
| type=valid_date, | ||
| type=validate_date, |
There was a problem hiding this comment.
s/validate_date/valid_date/
| from django.core.management.base import BaseCommand | ||
|
|
||
| from ralph_scrooge.utils.common import validate_date |
There was a problem hiding this comment.
s/validate_date/validate_date as valid_date/
|
@xor-xor fixed all comments |
xor-xor
approved these changes
Apr 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.