Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Homedir settings does not accept all possible settings #13

Closed
ghost opened this issue Nov 18, 2014 · 5 comments
Closed

Homedir settings does not accept all possible settings #13

ghost opened this issue Nov 18, 2014 · 5 comments
Labels

Comments

@ghost
Copy link

ghost commented Nov 18, 2014

It's impossible to change for example TIPBOARD_JAVASCRIPTS in ~/.tipboard/settings-local.py.
Now you need to change it in tipboard source settings (https://github.com/allegro/tipboard/blob/develop/tipboard/settings.py).
Check also other settings.. .

@ghost ghost added the bug label Nov 18, 2014
@eportico
Copy link

Oh thanks,
I integrated highcharts.js and leaflet maps easily in tipboard yet

@teebszet
Copy link

Cool! how did you do it?

@xor-xor
Copy link
Contributor

xor-xor commented Nov 19, 2014

One of the possibilities to do that is presented by @xliiv in #12 - therefore I suggest to continue this discussion over there 😉

@ghost ghost mentioned this issue Mar 27, 2015
@syphernl
Copy link
Contributor

Alternatively support for RequireJS could be added.

This is pretty easy to achieve:

  • Add require.js to the settings.py
  • From your module's js you can require any files using requirejs(['/static/my-custom.js']);

I have just tested this and seems to work just fine.
Eventually the massive list of jQuery includes could be decreased as well so they are only included when needed (via requireJS)

@ghost
Copy link
Author

ghost commented Mar 27, 2015

Great! You seem like you want to create a pull request? That's the spirit! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants