Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dutch language integration #69

Merged
merged 3 commits into from
Jul 7, 2023
Merged

Dutch language integration #69

merged 3 commits into from
Jul 7, 2023

Conversation

GHim9182
Copy link
Contributor

No description provided.

@GHim9182
Copy link
Contributor Author

Hi @MaciejLipinski, could you kindly take a look at this pull request? I'm available for discussions.

@GHim9182
Copy link
Contributor Author

Hi, any news on this?

@GHim9182
Copy link
Contributor Author

Hey, is this project still supported?

@jglaszka
Copy link
Collaborator

Hi @GHim9182, sorry for no answer - temporarily there was no person taking care of this project.
I will take a look at your code this week.

@jglaszka jglaszka self-requested a review June 30, 2023 18:36
@jglaszka jglaszka self-assigned this Jun 30, 2023
jglaszka
jglaszka requested changes Jul 2, 2023
View reviewed changes
Copy link
Collaborator

@jglaszka jglaszka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before I will check whole code, we need to add more test cases in unit tests.

@GHim9182 GHim9182 requested a review from jglaszka July 6, 2023 08:28
@GHim9182
Copy link
Contributor Author

GHim9182 commented Jul 6, 2023

Hi @jglaszka, it's done. I also merged all your changes of the last few days in the code. Could you check?

@jglaszka
Copy link
Collaborator

jglaszka commented Jul 6, 2023

I will take a look at this today.

jglaszka
jglaszka approved these changes Jul 6, 2023
View reviewed changes
Copy link
Collaborator

@jglaszka jglaszka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. :) tommorow I will merge this

@jglaszka jglaszka mentioned this pull request Jul 6, 2023
Open
@jglaszka jglaszka merged commit dfbe96b into allegro:master Jul 7, 2023
4 checks passed
@jglaszka jglaszka mentioned this pull request Jul 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jglaszka jglaszka jglaszka approved these changes

Assignees

@jglaszka jglaszka

Labels
to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@GHim9182 @jglaszka