Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade requests library #162

Merged
merged 3 commits into from
Aug 1, 2023

Conversation

jday1
Copy link
Contributor

@jday1 jday1 commented Jul 20, 2023

See #161.

@jkhenning
Copy link
Member

Hi @jday1,

As a rule, we try not to have open-ended constraints as this might lead to an unstable package breaking ClearML (sadly, we've already seen these issues in the past). I would much rather bump the version to the relevant number, or even add an open-ended constraint on the patch version?

@jday1
Copy link
Contributor Author

jday1 commented Jul 31, 2023

Hi @jday1,

As a rule, we try not to have open-ended constraints as this might lead to an unstable package breaking ClearML (sadly, we've already seen these issues in the past). I would much rather bump the version to the relevant number, or even add an open-ended constraint on the patch version?

No worries. I have made an adjustment.

@jkhenning jkhenning merged commit a56343f into allegroai:master Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants